Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address gcc6 build error #28

Merged
merged 1 commit into from
Jan 30, 2017
Merged

address gcc6 build error #28

merged 1 commit into from
Jan 30, 2017

Conversation

rojkov
Copy link
Contributor

@rojkov rojkov commented Jan 25, 2017

With gcc6, compiling fails with stdlib.h: No such file or directory,
as including '-isystem /usr/include' breaks with gcc6, cf.,
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129.

This commit addresses this issue for this package in the same way
it was addressed in various other ROS packages. A list of related
commits and pull requests is at:

ros/rosdistro#12783

Signed-off-by: Dmitry Rozhkov [email protected]

With gcc6, compiling fails with `stdlib.h: No such file or directory`,
as including '-isystem /usr/include' breaks with gcc6, cf.,
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129.

This commit addresses this issue for this package in the same way
it was addressed in various other ROS packages. A list of related
commits and pull requests is at:

  ros/rosdistro#12783

Signed-off-by: Dmitry Rozhkov <[email protected]>
@130s
Copy link
Contributor

130s commented Jan 30, 2017

@de-vri-es Would you want to take a look?

Copy link

@de-vri-es de-vri-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Really a shame that this breaks with --isystem, but I suppose its even more consistent with the way tiny xml is handled now.

@130s
Copy link
Contributor

130s commented Jan 30, 2017

Thanks @rojkov, @de-vri-es

New release that includes this will be made soon.

@130s 130s merged commit 29a81ed into moveit:kinetic-devel Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants