cleanup urdfdom compatibility #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... now relying on compatibility layer of urdf package
|
Should we hold off this change until the robot_model update is synced? |
|
+1 to holding off until sync |
|
This is overdue. Merging. |
130s
pushed a commit
to 130s/srdfdom
that referenced
this pull request
Jan 31, 2017
130s
pushed a commit
to 130s/srdfdom
that referenced
this pull request
Jan 31, 2017
130s
pushed a commit
to 130s/srdfdom
that referenced
this pull request
Jan 31, 2017
130s
pushed a commit
to 130s/srdfdom
that referenced
this pull request
Feb 3, 2017
130s
added a commit
to 130s/srdfdom
that referenced
this pull request
Feb 5, 2017
v4hn
added a commit
that referenced
this pull request
Feb 6, 2017
[Indigo] cleanup urdfdom compatibility (cherry-picking #27)
130s
reviewed
Jun 11, 2017
| @@ -41,8 +41,7 @@ | |||
| #include <string> | |||
| #include <vector> | |||
| #include <utility> | |||
| #include <urdf_model/model.h> | |||
| #include <srdfdom/urdfdom_compatibility.h> | |||
| #include <urdf/model.h> // TODO: replace with urdf_model/types.h in Lunar | |||
There was a problem hiding this comment.
// TODO: replace with urdf_model/types.h in Lunar
Does this still hold?
There was a problem hiding this comment.
I tried replacing it on a Ubuntu Zesty system and got an error:
/root/ros/ws_catkin/src/srdfdom/include/srdfdom/model.h:66:28: error: 'ModelInterface' in namespace 'urdf' does not name a type
Which I have not looked into
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... now relying on compatibility layer of urdf package: ros/robot_model#160