[package.xml] Add active maintainers. Much wrong info. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <author email="[email protected]">Guillaume Walck</author> | ||
| <maintainer email="[email protected]">Ioan Sucan</maintainer> | ||
| <maintainer email="[email protected]">Ioan Sucan</maintainer> |
There was a problem hiding this comment.
I just emailed @isucan to see if he wants to remain maintainer for packages like this, I'm fine either way
There was a problem hiding this comment.
he suggested he be removed "from all instances" of package.xmls with him as a maintainer. I think we should also start a separate discussion on Discourse to find new active maintainers for all the packages - want to start that?
|
This is great, thanks! |
[package.xml] Alphabetic order.
|
Comment addressed. |
| <build_depend>libconsole-bridge-dev</build_depend> | ||
| <build_depend>liburdfdom-headers-dev</build_depend> | ||
| <build_depend>rostest</build_depend> |
There was a problem hiding this comment.
shouldn't this be a test_depend instead?
|
Comment addressed again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.