Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the reason of image_view and rqt_image_view are separately implemented #158

Closed
130s opened this issue Nov 16, 2015 · 1 comment
Closed
Labels

Comments

@130s
Copy link
Member

130s commented Nov 16, 2015

Title says pretty much everything. I'm just wondering.

@vrabaud
Copy link
Contributor

vrabaud commented Nov 17, 2015

image_view is lightwright: it's only OpenCV. You choose a topic on the command line, view an image and save it. It uses a nodelet which actually creates problems on some platforms /OpenCV.
rqt_image_view is integrated in rqt which allows dynamic choosing of the topic, refresh rate, pause, full screen.
rqt_image_view should just be image_view with a better GUI. Now, as image_view historically uses nodelets, rqt_image_view did not use that nodelet and re-wrote the code (plus Qt does nto allow grayscale images to be displayed, so conversions are different).

That's why I started writing this common code. Then again, image_view needs to be re-written like rqt with only a stupid loop that displays imaging. No more nodelets ! (because the threading model of nodelets interferes with the threading model of OpenCV for GUIs). I just could never find the time for it .... If you feel like, please make a pull request, I know it is totally trivial ! More discussion at ros-perception/vision_opencv#81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants