Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix goal_checker_plugin parameter format #3137

Merged

Conversation

ipa-kut
Copy link
Contributor

@ipa-kut ipa-kut commented Aug 22, 2022


Basic Info

Info Please fill out this column
Tickets #3136
Primary OS tested on Ubuntu 22.04/20.04
Robotic platform tested on Multi robot gazebo simulation

Description of contribution in a few bullet points

Description of documentation updates required from your changes

None


Future work that may be required in bullet points

None

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2022

@ipa-kut, all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @humble, but it must be in main
to have these changes reflected into new distributions.

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2022

@ipa-kut, please properly fill in PR template in the future. @SteveMacenski, use this instead.

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@SteveMacenski SteveMacenski changed the base branch from humble to main August 22, 2022 16:06
@SteveMacenski SteveMacenski changed the base branch from main to humble August 22, 2022 16:06
@SteveMacenski SteveMacenski merged commit 0bae341 into ros-navigation:humble Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants