Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fastcov to speed up coverage for CI #2391

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Use fastcov to speed up coverage for CI #2391

merged 2 commits into from
Jun 8, 2021

Conversation

ruffsl
Copy link
Member

@ruffsl ruffsl commented Jun 6, 2021

Make use of fastcov to speed up CI:
https://github.com/RPGillespie6/fastcov

@ruffsl ruffsl marked this pull request as ready for review June 7, 2021 00:25
@ruffsl ruffsl requested a review from SteveMacenski June 7, 2021 00:25
@SteveMacenski
Copy link
Member

When did that start taking 30 minutes? Looking back only a month it was taking about 2 minutes https://app.circleci.com/pipelines/github/ros-planning/navigation2/5301/workflows/1131a535-ce5b-4bc2-bd26-0b3af0a0836f/jobs/19546/steps

@ruffsl
Copy link
Member Author

ruffsl commented Jun 8, 2021

With the gap in CI runs from the galactic breakages, I could only narrow down the regression between theses workflow runs:

I'm not sure what changed here though. Any guesses? Some of my guesses:

  • Performance regression upstream in lcov package
  • Increase or change in how we generate coverage with gcc

The coverage mixin hasn't changed for more than a year, so the cmake and python args wouldn't have changed.

https://github.com/colcon/colcon-mixin-repository/blob/master/coverage.mixin

@SteveMacenski
Copy link
Member

SteveMacenski commented Jun 8, 2021

ros2/rclcpp@0251f70 its also the date rclcpp released 11.0.0, so maybe something in the ROS2 stack was updated and got back up to us in compile flags?

Only other thing I could think of it this commit #2330 did something odd, but I don't see how that's possible

I'm good with this change either way once you are

@ruffsl
Copy link
Member Author

ruffsl commented Jun 8, 2021

I'm good with this change either way once you are

Codcov doesn't show any change in coverage for this PR, so I'll go ahead and merge.

https://codecov.io/github/ros-planning/navigation2/commit/dbc8153498f562961106f8876f5e88756b1e4ba7

I'm also going to open a ticket with colcon-lcov-result so ask if they've noticed the same performance regression, but at least this should resolve our issue in the meantime.

@ruffsl ruffsl merged commit 2c9b2c9 into main Jun 8, 2021
@ruffsl ruffsl deleted the ci-coverage branch June 8, 2021 17:19
ruffsl added a commit to ruffsl/navigation2 that referenced this pull request Jun 19, 2021
ruffsl added a commit to ruffsl/navigation2 that referenced this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants