-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fastcov to speed up coverage for CI #2391
Conversation
A rather nice improvement... Not too shabby :P Before: 31m 25sAfter: 34s |
When did that start taking 30 minutes? Looking back only a month it was taking about 2 minutes https://app.circleci.com/pipelines/github/ros-planning/navigation2/5301/workflows/1131a535-ce5b-4bc2-bd26-0b3af0a0836f/jobs/19546/steps |
With the gap in CI runs from the galactic breakages, I could only narrow down the regression between theses workflow runs:
I'm not sure what changed here though. Any guesses? Some of my guesses:
The coverage mixin hasn't changed for more than a year, so the cmake and python args wouldn't have changed. https://github.com/colcon/colcon-mixin-repository/blob/master/coverage.mixin |
ros2/rclcpp@0251f70 its also the date rclcpp released 11.0.0, so maybe something in the ROS2 stack was updated and got back up to us in compile flags? Only other thing I could think of it this commit #2330 did something odd, but I don't see how that's possible I'm good with this change either way once you are |
Codcov doesn't show any change in coverage for this PR, so I'll go ahead and merge. https://codecov.io/github/ros-planning/navigation2/commit/dbc8153498f562961106f8876f5e88756b1e4ba7 I'm also going to open a ticket with |
This reverts commit 2c9b2c9.
Make use of
fastcov
to speed up CI:https://github.com/RPGillespie6/fastcov