-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nav2_gps_waypoint_follower #2111
Closed
+340
−49
Closed
Changes from 3 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
5f33ac5
Add nav2_gps_waypoint_follower
jediofgever 277c1e1
use correct client node while calling it to spin
jediofgever c6ee437
changed after 1'st review
jediofgever 7b6f8cf
apply requested changes
jediofgever ac94d2d
nav2_util::ServiceClient instead of CallbackGroup
jediofgever cd9a287
another iteration to adress issues
jediofgever 9c0e408
update poses with function in the follower logic
jediofgever f94e3b3
add deps of robot_localization: diagnostics
jediofgever e4fe184
fix typo in underlay.repo
jediofgever c2f4d95
add deps of robot_localization: geographic_info
jediofgever 98804f1
minor clean-ups
jediofgever e95f55a
merge ros-planning::navigation2::main into jediofgever::navigation2::…
jediofgever 960bb13
bond_core version has been updated
jediofgever 623c6a6
rotation should also be considered in GPS WPFing
jediofgever ef57df0
use better namings related to gps wpf orientation
jediofgever 063b8e7
handle cpplint errors
jediofgever e544fde
tf_listener needs to be initialized
jediofgever 84c7ef0
apply requested changes
jediofgever d2c4127
apply requested changes 2.5/3.0
jediofgever aee13ca
apply requested changes 3.0/3.0
jediofgever 4f83167
fix misplaced ";"
jediofgever 6e322ea
use run time param for gps transform timeout
jediofgever 81c7c64
change timeout var name
jediofgever 7c69520
make use of stop_on_failure for GPS too
jediofgever 7889ae3
passing emptywaypont vectors are seen as failure
jediofgever c28b93e
pull changes from ros-planing::navigation2::main
jediofgever c6613a8
update warning for empty requests
jediofgever 0d0d59c
get upstream changes
jediofgever d7e2ad4
consider utm -> map yaw offset
jediofgever d6527d2
fix missed RCLCPP info
jediofgever f99ebff
reorrect action;s name
jediofgever e0a3aa6
get mainstream changes
jediofgever 5fcfb83
waypoint stamps need to be updated
jediofgever File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
#goal definition | ||
sensor_msgs/NavSatFix[] waypoints | ||
--- | ||
#result definition | ||
int32[] missed_waypoints | ||
--- | ||
#feedback | ||
uint32 current_waypoint |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need any new parameters or actions exposed by the waypoint follower added to the navigation.ros.org website configuration docs. Also adding a node in the migration guide that WP follower now does GPS in the Foxy migration guide. The WP follower configuration page should also add a paragraph on top with the basic package description mentioning GPS waypoint following now. That's part of another documentation PR, just FYI. You don't need to do this right now, we can wait until this is ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, lets make this PR good enough to merge then
navigation.ros.org
will be next