-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rosdep does not enforce version_gte tag #325
Comments
Therefore entries like I agree that ideally this should be something that However, @NikolausDemmel is just now starting a GSoC to work on a improved version of |
@awesomebytes I'm sorry if this is an inconvenient answer for now, but if this does address your question can you please close this issue? Otherwise, feel free to continue the discussion. |
Thank you for your fast response @wjwwood, I'm not so happy with the answer as I thought it would be a mere bug or that I just forgot to do something. |
You can feel free to keep it open, but I won't be spending anytime on it for now since we have plans to address this in the new tool. |
@awesomebytes: What would you expect rosdep to do in this situation? For apt, the only action I can imagine right now for an already installed (ros-) package is upgrading to the latest version and erroring/warning if the versioned dependency is not satisfied by that. (It could potentially also try to update the apt cache if it is outdated). |
@NikolausDemmel that's exactly what I was expecting rosdep to do! Or at least give me a warning stating that the dependency is installed but in a lower version and that might cause trouble. |
@awesomebytes: Ok, I'll keep it in mind for the new tool. Not sure if we will be able to include it in the current version. |
@NikolausDemmel Ok, thank you for your interest :) and also congratulations on your GSoC! |
Thanks ;-). We're just really starting now and one of the first things involves collecting current shortcomings of rosdep we would like to alleviate in the new tool, so these kinds of requests with concrete/relevant use case are very valuable. |
+1 |
I agree that with Debian packages, there are just two options - update to latest, or fail (or ignore the version). But with pip, things get more interesting, because you can easily force version number. I know that REP-140 has been there for a long time, but wouldn't it deserve a mention about rosdep not supporting these tags at all? Or at least a link to this issue? I know that other tools than rosdep may process the package manifest, but rosdep is the first I think about when I see a package manifest. |
What's the status of this issue? I wound up here after my (failed) attempts to get |
I would also like to know the status of this issue? |
The status is that noone is working on this. Also for ROS2, there is currently no work towards replacing rosdep AFAIK. A while ago there was work on a "new tool", xylem, which was intended as a replacement for rosdep with a ROS-independent core. I belive @wjwwood started it, then I worked on this for a while and together with @wjwwood and @tfoote we had some discussion on how this issue should be addressed in xylem (see https://xylem.readthedocs.io/en/latest/design.html#versions-in-rules-files). However, due to bandwidth limitations (I started a new job), this never reached beyond prototype stage and its not ready to replace rosdep. In particular version checking wasn't even implemented in the prototype, IIRC. From OSRF side, I guess rosdep has been working well enough, so other projects were more pressing. |
That's an accurate summary. |
Thanks for the accurate and quick reply. We'll go back to using our own setup script then. |
Following this documentation:
http://www.ros.org/reps/rep-0127.html#build-depend-multiple
I added to my package.xml the line:
And I executed (at my workspace, just over src folder):
And I got:
But my system ros-hydro-sensor-msgs is:
The package itself is: https://github.com/pal-robotics/object_recognition_clusters just in case.
The text was updated successfully, but these errors were encountered: