Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Suite3 option with Ubuntu Focal. #271

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Conversation

nuclearsandwich
Copy link
Contributor

@nuclearsandwich nuclearsandwich commented Dec 3, 2019

This configuration option requires two recent changes in stdeb and
ros_release_python:

The option allows a different set of suites to be set for Python 3
releases allowing us to forestall releasing Python2 versions of these
packages for platforms where we don't plan to support Python 2.

This configuration option requires two recent changes in stdeb and
ros_release_python:
* astraw/stdeb#147
* ros-infrastructure/ros_release_python#33

The option allows a different set of suites to be set for Python 3
releases allowing us to forestall releasing Python2 versions of these
packages for platforms where we don't plan to support Python 2.
@dirk-thomas
Copy link
Member

ros-infrastructure/ros_release_python#33 has nothing to do with this change.

@nuclearsandwich
Copy link
Contributor Author

nuclearsandwich commented Dec 3, 2019

ros-infrastructure/ros_release_python#33 has nothing to do with this change.

--include doesn't work at all, suite3 or no without that change. This PR won't have the intended effect without it. I updated the PR body to clarify the relationship.

@dirk-thomas
Copy link
Member

--include doesn't work at all, suite3 or no without that change. This PR won't have the intended effect without it.

Yes, --include was broken. Using Suite3 or just Suite doesn't make any difference. Therefore these two changes are orthogonal.

@dirk-thomas dirk-thomas merged commit 590b2e7 into master Dec 3, 2019
@nuclearsandwich nuclearsandwich deleted the release-python3-focal branch December 3, 2019 20:15
@audrow audrow mentioned this pull request Jun 3, 2021
82 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants