Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit early on patch failure if bloom is being run non-interactively. #668

Merged
merged 5 commits into from
Apr 19, 2022

Commits on Apr 18, 2022

  1. Export BLOOM_NON_INTERACTIVE to track actions environment.

    If git-bloom-release is run non-interactively then that should be
    propagated to the actions command so that actions are not blocked on
    interactivity.
    
    This patch also makes the minor optimization of only making one copy of
    the environment to pass to the actions run. I don't think this makes a
    major difference in performance but it is one less thing to worry about
    and environment changes from children should not persist to subsequent
    children or "bubble up" to the parent process.
    nuclearsandwich committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    a9fe30c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f278989 View commit details
    Browse the repository at this point in the history
  3. Indentation.

    nuclearsandwich committed Apr 18, 2022
    Configuration menu
    Copy the full SHA
    65197b1 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. Configuration menu
    Copy the full SHA
    791c4e6 View commit details
    Browse the repository at this point in the history
  2. Revert "Export BLOOM_NON_INTERACTIVE to track actions environment."

    This reverts commit a9fe30c.
    The updated implementation relies on using isatty for interactive
    terminal detection rather than an exported environment variable.
    nuclearsandwich committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    65bf29c View commit details
    Browse the repository at this point in the history