Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a number of build warnings #137

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Fix a number of build warnings #137

merged 3 commits into from
Jun 14, 2023

Conversation

hellantos
Copy link
Member

No description provided.

Signed-off-by: Christoph Hellmann Santos <[email protected]>
@hellantos hellantos linked an issue Jun 9, 2023 that may be closed by this pull request
@hellantos hellantos added this to the Beta Release v0.2.0-beta milestone Jun 9, 2023
Christoph Hellmann Santos added 2 commits June 9, 2023 17:04
Signed-off-by: Christoph Hellmann Santos <[email protected]>
Signed-off-by: Christoph Hellmann Santos <[email protected]>
@destogl
Copy link
Collaborator

destogl commented Jun 14, 2023

When you are already on fixing warnings, we just learned this week that -Wconversion flag is not set with -Wall – unfortunately the learning was not easy, and we lost a few hours to debugging issues in the tests caused by implicit casting and narrowing types.

I propose to add this here – just to be sure that all castings are used properly – especially since we are converting a lot between doubles and (u)ints.

check here for more details: ros-controls/ros2_control#1053

@hellantos
Copy link
Member Author

@destogl I've made another issue here #135.

@hellantos hellantos merged commit 3ebc4f0 into master Jun 14, 2023
@destogl destogl deleted the 135-fix-build-warnings branch June 14, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix build warnings
2 participants