Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export canopen_fake_slaves include directories #227

Closed
MartinCornelis2 opened this issue Nov 20, 2023 · 2 comments
Closed

Export canopen_fake_slaves include directories #227

MartinCornelis2 opened this issue Nov 20, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@MartinCornelis2
Copy link

Ubuntu 22.04
ROS Humble

I want to derive my own Mocked devices from either the ros2_canopen::BaseSlave or the ros2_canopen::BasicSlave, however the include folder does not seem to get exported.

Is there a reason why

install(
  DIRECTORY include/
  DESTINATION include
)
ament_export_include_directories(
  include
)

is ommitted from the CMakelists.txt in the ROS Humble version (didn't check other versions yet)?

Or am I not supposed to derive my Mock devices from these classes?
With the way things are setup now you also have to override the entire run() of the BaseSlave/BasicSlave, just to feed your own slave class in i.e. in cia402_slave.hpp:
ros2_canopen::CIA402MockSlave slave(timer, chan, slave_config_.c_str(), "", node_id_);
or in my case:
BLinkMockSlave slave(timer, chan, slave_config_.c_str(), "", node_id_);
I feel like this will lead to a lot of code duplication if you want to create multiple mocked devices.

Please let me know if I can/should open a PR, or if I am not supposed to use canopen_fake_slaves in this way.

@MartinCornelis2 MartinCornelis2 added the enhancement New feature or request label Nov 20, 2023
@hellantos
Copy link
Member

Honestly, the fake slaves package has not received much love. It would be wonderful to get some help for it.

@kurtist123
Copy link
Contributor

I implemented this enhancement here: #265

I implemented the enhancement on the master branch but I would also like it on the humble branch. What is the process to get this back merged into the humble branch?

@ipa-vsp ipa-vsp closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants