Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is "dv = current_vel+last_vel " should be modified to "dv = current_vel - last_vel" in industrial_robot_simulator package file #277

Open
dbdxnuliba opened this issue Aug 18, 2021 · 2 comments
Labels

Comments

@dbdxnuliba
Copy link

dbdxnuliba commented Aug 18, 2021

in industrial_robot_simulator package the pyhon file

 def accelerate(self, last_pt, current_pt, current_time, delta_time):
        intermediate_pt = JointTrajectoryPoint()
        #rospy.logerr("debug : enter accelerate() in industrial_robot_simulator")

        for last_joint, current_joint, last_vel, current_vel in zip(last_pt.positions, current_pt.positions, last_pt.velocities, current_pt.velocities):
            delta_x = current_joint-last_joint
            dv = current_vel+last_vel

is "dv = current_vel+last_vel " should be modified to "dv = current_vel - last_vel"

@gavanderhoorn
Copy link
Member

From a quick look it looks like you could be right.

Could you submit a PR?

@dbdxnuliba
Copy link
Author

but the result about "delta_x = current_joint+last_joint" is better than "delta_x = current_joint-last_joint"
may be your raw code is right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants