Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow re-use of Docker image (reopen #319) #341

Merged
merged 5 commits into from
Jan 2, 2019
Merged

Allow re-use of Docker image (reopen #319) #341

merged 5 commits into from
Jan 2, 2019

Commits on Dec 23, 2018

  1. expose COMMIT_IMAGE variable to user. Updates related documentation … 

    …and variables.
    @AustinDeric @130s
    AustinDeric authored and 130s committed Dec 23, 2018
    Configuration menu
    Copy the full SHA
    b8b247e View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2018

  1. Rename the variables to clarify they are related to Docker. 

    Addressing https://github.com/ros-industrial/industrial_ci/pull/319/files#r220267620

[feat:commit_img] Add a section to readme.

[feat:commit_img] Remove 'COMMIT_IMAGE' variable. Add a test.

Address https://github.com/ros-industrial/industrial_ci/pull/319/files#r222089723

[feat:commit_img] Adding a test for DOCKER_COMMIT_IMAGE.

[feat:commit_img] Simplify 'docker commit' variable names. Revert change in rerun_ci (address a review commnet ros-industrial#319 (review)).

Rename the variables to clarify they are related to Docker.

Addressing https://github.com/ros-industrial/industrial_ci/pull/319/files#r220267620

expose COMMIT_IMAGE variable to user. Updates related documentation and variables.

[feat:commit_img] Remove 'COMMIT_IMAGE' variable. Add a test.

Address https://github.com/ros-industrial/industrial_ci/pull/319/files#r222089723

[feat:commit_img] Simplify 'docker commit' variable names. Revert change in rerun_ci (address a review commnet ros-industrial#319 (review)).

[doc] Remove unused, obsolete var name (address https://github.com/ros-industrial/industrial_ci/pull/319/files#r230591444)
[doc] Remove unused var (address https://github.com/ros-industrial/industrial_ci/pull/319/files#r230591088).

[feat:commit_img] Simplified test (attempting to address https://github.com/ros-industrial/industrial_ci/pull/319/files#r230591026)

[feat:commit_img] Simplify test logic (based on suggestion AustinDeric#3 (comment)).

[feat:commit_img] Removed obsolete logic (address ros-industrial#319 (comment)).

[feat:commit_img] address review comments (ros-industrial#319 (review))

[docker.sh] Indentation (ros-industrial#341 (comment)).
    @130s
    130s committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    ecfcd35 View commit details
    Browse the repository at this point in the history

  2. [travis.yml] Fix yaml format.

    @130s
    130s committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    ef50524 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2019

  1. [rerun.sh] Rename some variables to adjust to docker commit feature.

    @130s
    130s committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    289a089 View commit details
    Browse the repository at this point in the history

  2. [doc][rerun.sh] Add some exception.

    @130s
    130s committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    892c4e9 View commit details
    Browse the repository at this point in the history