Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to access to Docker image built inside industrial_ci #318

Closed
130s opened this issue Sep 14, 2018 · 5 comments
Closed

Option to access to Docker image built inside industrial_ci #318

130s opened this issue Sep 14, 2018 · 5 comments

Comments

@130s
Copy link
Member

130s commented Sep 14, 2018

@ipa-mdl Is there any reason why there is no way to access the docker image built during industrial_ci process?

I see in a recent change there's an option to docker commit the built image

docker commit -m "$_COMMIT_IMAGE_MSG" "$cid" $commit_image > /dev/null
, but the option is not publicly exposed (only available when running rerun_ci script AFAIUC). And regardless of which option to start industrial_ci, the built image is deleted
docker rm "$cid" > /dev/null
.

If there's no problem, I'm interested in adding a generic option to get an access to the built image.

In my usecase, I want to store Docker images with the latest code. To achieve that currently I have CI jobs that run docker build, separately from industrial_ci jobs. While that works ok, since in industrial_ci an image is already built I'm interested in re-using what's already built by industrial_ci. That allows to use the same image for testing on CI and for the future purpose, and also save some CI time (it's non-trivial for a private repo on a hosting service). It could also allow a usecase where the update gets deployed by container (common in web app world, but it's possible in robotics as well).

CC @AustinDeric

@mathias-luedtke
Copy link
Member

Is there any reason why there is no way to access the docker image built during industrial_ci process?
I see in a recent change there's an option to docker commit the built image

Yes, #279 was merged while it still was WIP.

but the option is not publicly exposed (only available when running rerun_ci script AFAIUC).

#279 (comment)

Just rename _COMMIT_IMAGE (and perhaps _COMMIT_IMAGE_MSG) and add documentation.

@mathias-luedtke
Copy link
Member

And regardless of which option to start industrial_ci, the built image is deleted

The container gets deleted, but not the image.

@AustinDeric
Copy link

AustinDeric commented Sep 17, 2018

@ipa-mdl & @130s

The container gets deleted, but not the image.

I cannot find the image that gets built by industrial CI. i run docker images after the industrial ci script and it doesn't return the recently built image:

  after_script:
    - docker images

Furthermore, looking at the build logs, the last command is docker rm and i do not see a commit of the image.

@mathias-luedtke
Copy link
Member

The commit will only happen if _COMMIT_IMAGE is set.

@130s
Copy link
Member Author

130s commented Jan 3, 2019

Addressed by #341

@130s 130s closed this as completed Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants