-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to access to Docker image built inside industrial_ci #318
Comments
Yes, #279 was merged while it still was WIP.
Just rename |
The container gets deleted, but not the image. |
@ipa-mdl & @130s
I cannot find the image that gets built by industrial CI. i run
Furthermore, looking at the build logs, the last command is |
The commit will only happen if |
Addressed by #341 |
@ipa-mdl Is there any reason why there is no way to access the docker image built during industrial_ci process?
I see in a recent change there's an option to
docker commit
the built imageindustrial_ci/industrial_ci/src/docker.sh
Line 114 in d8ac934
rerun_ci
script AFAIUC). And regardless of which option to start industrial_ci, the built image is deletedindustrial_ci/industrial_ci/src/docker.sh
Line 116 in d8ac934
If there's no problem, I'm interested in adding a generic option to get an access to the built image.
In my usecase, I want to store Docker images with the latest code. To achieve that currently I have CI jobs that run
docker build
, separately from industrial_ci jobs. While that works ok, since in industrial_ci an image is already built I'm interested in re-using what's already built by industrial_ci. That allows to use the same image for testing on CI and for the future purpose, and also save some CI time (it's non-trivial for a private repo on a hosting service). It could also allow a usecase where the update gets deployed by container (common in web app world, but it's possible in robotics as well).CC @AustinDeric
The text was updated successfully, but these errors were encountered: