You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm starting to notice an anti-pattern which is cluttering up a lot of
ros-industrial code. Each header file is in its own namespace, making the
imports too long to specify inline. Thus, the pattern is to import every
header file with the "using namespace industrial::message_handler;", a practice
which ends up defeating the point of namespaces almost entirely. How about
instead we just reduce all namespaces to only "industrial" and use them inline.
Original issue reported on code.google.com by [email protected] on 23 May 2013 at 5:10
The text was updated successfully, but these errors were encountered:
The namespace convention was taken from the ros C++ style guide (
http://ros.org/wiki/CppStyleGuide#Namespaces-1 ) and based on an example within
the ROS libraries (although I forget which one). I agree that this causes some
physical code clutter. Class namespaces allow complicated class files to be
encapsulated as well, so there is some merit to using them.
The main reason not to make such a change is that it would touch lots of code
within ROS-Industrial and anybody else's code that depends on ours. From a
user perspective, such a change would break their code without adding any new
functionality. There is room for discussion, but I think the effect on the end
user should be the highest consideration.
Original issue reported on code.google.com by
[email protected]
on 23 May 2013 at 5:10The text was updated successfully, but these errors were encountered: