Revert ForceTorqueSensorBroadcaster changes in PR #698 #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameters on configure (ros-controls#698)" This reverts commit 32aaef7.
github-actions
bot
requested review from
bmagyar,
DasRoteSkelett,
destogl,
livanov93,
mcbed,
peterdavidfagan and
progtologist
saikishor
changed the title
bmagyar
approved these changes
Jan 29, 2024
|
@saikishor I've cherry-picked this commit to |
|
Awesome, then we can backport these changes |
christophfroehlich
added
backport-humble
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR : #698 shouldn't be needed anymore after the newly merged parameter fix from : ros-controls/ros2_control#1293
@Noel215 can you please test it and let us know?
Thank you!