Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JTC] Cancel active goal in on_deactivate (backport #962) #971

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 11, 2024

This is an automatic backport of pull request #962 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (979bdb3) 47.30% compared to head (df5cdfc) 47.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             iron     #971      +/-   ##
==========================================
- Coverage   47.30%   47.07%   -0.23%     
==========================================
  Files          40       40              
  Lines        3655     3664       +9     
  Branches     1728     1739      +11     
==========================================
- Hits         1729     1725       -4     
- Misses        730      736       +6     
- Partials     1196     1203       +7     
Flag Coverage Δ
unittests 47.07% <0.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ory_controller/src/joint_trajectory_controller.cpp 47.47% <0.00%> (-1.15%) ⬇️

@bmagyar bmagyar merged commit 73a96e9 into iron Jan 11, 2024
13 of 15 checks passed
@bmagyar bmagyar deleted the mergify/bp/iron/pr-962 branch January 11, 2024 18:15
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
…os-controls#971)

---------

Co-authored-by: AndyZe <[email protected]>
Co-authored-by: bijoua <[email protected]>
Co-authored-by: Guillaume Walck <[email protected]>
Co-authored-by: Christoph Fröhlich <[email protected]>
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Co-authored-by: Manuel M <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants