Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backports to iron #869

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Backports to iron #869

merged 4 commits into from
Nov 30, 2023

Conversation

christophfroehlich
Copy link
Contributor

A manual backport PR to fix conflicts of open backports.

Replaces #837 #853 #862 #866

christophfroehlich and others added 4 commits November 29, 2023 19:01
@christophfroehlich @destogl
[JTC] Fix tests when state offset is used (backport ros-controls#797)
58fe00a 
* Simplify initialization of states
* Rename read_state_from_hardware method
* Don't set state_desired in on_activate
---------

Co-authored-by: Dr. Denis <[email protected]>
@christophfroehlich
[JTC] Fix dynamic reconfigure of tolerances (backport ros-controls#849)
4a9b07b 
* Fix dynamic reconfigure of tolerances

* Fix static cast syntax
@christophfroehlich
[JTC] Improve update methods for tests (backport ros-controls#858)
a40f917
@christophfroehlich
Increase test coverage of interface configuration getters (backport r…
4dba01d 
…os-controls#856)
@bmagyar bmagyar merged commit 1f93eb1 into ros-controls:iron Nov 30, 2023
10 of 13 checks passed
@christophfroehlich christophfroehlich deleted the backport/iron branch November 30, 2023 11:36
@RobertWilbrandt RobertWilbrandt mentioned this pull request Nov 30, 2023
Merged
@VinDp VinDp mentioned this pull request Dec 4, 2023
Merged
@RobertWilbrandt
Copy link
Contributor

Doing such backports and releasing them one day before sync makes it really hard to depend on these packages. For our ur_controllers this backport meant that we were not able to adjust to the API changes in time for the sync, and our builds now failing in the buildfarm.

@christophfroehlich
Copy link
Contributor Author

Hm, maybe we haven't thought about the API break of renaming read_state_from_hardware while backporting (I think this is the only break here). We should work on bringing the scaled JTC upstream into this package (#301, I guess this is the conflict here?).

@RobertWilbrandt
Copy link
Contributor

Yeah that will probably be the best long-term solution for us.

@bmagyar
Copy link
Member

bmagyar commented Dec 6, 2023

Sorry for the inconvenience caused guys.

I'd suggest also following this up with the ROS Boss for Iron. Releases too close to the sync are typically held. The entire purpose of the testing repo is to give some mileage to new releases before they go into sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@destogl destogl Awaiting requested review from destogl

@duringhof duringhof Awaiting requested review from duringhof

@homalozoa homalozoa Awaiting requested review from homalozoa

@livanov93 livanov93 Awaiting requested review from livanov93

@LukasMacha97 LukasMacha97 Awaiting requested review from LukasMacha97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christophfroehlich @RobertWilbrandt @bmagyar