Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JTC] Add option to hold position on last command #794

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Oct 9, 2023

As suggested with #759, there is now an option to hold the position of the last command instead of the state read from the hardware.

I added a new parameter, but we could also use the already existing open_loop_control? @firesurfer Is there a use case for open_loop_control==false but one would like to hold the last commanded point?

Still missing:

  • Tests

This closes #759

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #794 (ef6d37e) into master (2c6d7a6) will decrease coverage by 14.41%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

❗ Current head ef6d37e differs from pull request most recent head cd6e415. Consider uploading reports for the commit cd6e415 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #794       +/-   ##
===========================================
- Coverage   45.29%   30.88%   -14.41%     
===========================================
  Files          40        7       -33     
  Lines        3663      832     -2831     
  Branches     1730      505     -1225     
===========================================
- Hits         1659      257     -1402     
+ Misses        821      133      -688     
+ Partials     1183      442      -741     
Flag Coverage Δ
unittests 30.88% <ø> (-14.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 37 files with indirect coverage changes

@christophfroehlich christophfroehlich marked this pull request as draft October 9, 2023 18:23
@firesurfer
Copy link
Contributor

@christophfroehlich Thanks for adding this option.

I am not sure actually about the use case. But I think reusing the parameter could be quite confusing

@christophfroehlich
Copy link
Contributor Author

See #811, we will use a different solution.

@christophfroehlich christophfroehlich deleted the jtc/hold_position_mode branch November 15, 2023 19:55
henrygerardmoore pushed a commit to henrygerardmoore/ros2_controllers that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JTC] set_hold_position results into not exactly reaching desired target
2 participants