Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPIO controller onn humble #1403

Conversation

Wiktor-99
Copy link
Contributor

Compared to the rolling version, I have made the following changes:

  • Fixed compilation issues
  • Removed fetching GPIO state interfaces from URDF
  • Aligned unit tests (UTs)
  • Updated documentation

This comment was marked as resolved.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, changes look good!

@christophfroehlich christophfroehlich merged commit 1d8a0d4 into ros-controls:mergify/bp/humble/pr-1251 Dec 1, 2024
2 checks passed
christophfroehlich added a commit that referenced this pull request Dec 6, 2024
* Gpio command controller (#1251)

---------

Co-authored-by: m.bednarczyk <[email protected]>
Co-authored-by: Maciej Bednarczyk <[email protected]>
Co-authored-by: Bence Magyar <[email protected]>
Co-authored-by: Christoph Fröhlich <[email protected]>
Co-authored-by: Christoph Froehlich <[email protected]>
Co-authored-by: Sai Kishor Kothakota <[email protected]>
(cherry picked from commit 0590c6a)

# Conflicts:
#	doc/release_notes.rst

* Update release_notes.rst

* Fix GPIO controller on humble (#1403)

* Add compatibility build for humble+jazzy distro (#1368) (#1373)

(cherry picked from commit 3b600f2)

Co-authored-by: Christoph Fröhlich <[email protected]>

* Fix compilation and align UTs

* Update docs

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Christoph Fröhlich <[email protected]>

* Remove range-loop-construct compile options

* Add missing dependency to gpio_controllers (#1410) (#1412)

(cherry picked from commit dc60f6f)

Co-authored-by: Christoph Fröhlich <[email protected]>

---------

Co-authored-by: Wiktor Bajor <[email protected]>
Co-authored-by: Christoph Fröhlich <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Christoph Froehlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants