-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TractionLimiter: Fix wrong input checks #1341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
backport-humble
This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
backport-iron
labels
Nov 1, 2024
github-actions
bot
requested review from
bmagyar,
DasRoteSkelett,
destogl,
erickisos,
mamueluth,
mcbed and
VX792
November 1, 2024 20:33
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1341 +/- ##
==========================================
+ Coverage 80.89% 81.47% +0.57%
==========================================
Files 109 110 +1
Lines 9696 9821 +125
Branches 842 858 +16
==========================================
+ Hits 7844 8002 +158
+ Misses 1574 1541 -33
Partials 278 278
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bmagyar
approved these changes
Nov 4, 2024
christophfroehlich
force-pushed
the
fix/traction_limiter
branch
from
November 11, 2024 16:24
3d0f236
to
6c7bd61
Compare
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
(cherry picked from commit 28dd7e1)
mergify bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
(cherry picked from commit 28dd7e1)
This was referenced Nov 12, 2024
bmagyar
pushed a commit
that referenced
this pull request
Nov 12, 2024
bmagyar
pushed a commit
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on ros-controls/control_toolbox#212 and writing tests, I found some issues with the TractionLimiter of the tricycle_controller.