Add -Wconversion flag to protect future developments (backport #667) #1322
+51
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same reasons as ros-controls/ros2_control#1053
explicitly catching errors of time being zero in
forward_command_controller
seeI think there might be an ABI breaking in JTC with one argument changed from
int
tosize_t
. I did not know what to do there, and went for ABI breaking but I could also make it astatic_cast
if preferred. seeThis is an automatic backport of pull request #667 done by [Mergify](https://mergify.com).