-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
steering_controllers_library: Add reduce_wheel_speed_until_steering_reached
parameter
#1314
base: master
Are you sure you want to change the base?
steering_controllers_library: Add reduce_wheel_speed_until_steering_reached
parameter
#1314
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1314 +/- ##
==========================================
+ Coverage 83.57% 83.69% +0.12%
==========================================
Files 122 122
Lines 10987 11052 +65
Branches 939 940 +1
==========================================
+ Hits 9182 9250 +68
- Misses 1490 1491 +1
+ Partials 315 311 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small comment about docs, otherwise great!
I agree to break this on Humble
@@ -57,6 +57,7 @@ steering_controllers_library | |||
* Changing default int values to double in steering controller's yaml file. The controllers should now initialize successfully without specifying these parameters (`#927 <https://github.com/ros-controls/ros2_controllers/pull/927>`_). | |||
* A fix for Ackermann steering odometry was added (`#921 <https://github.com/ros-controls/ros2_controllers/pull/921>`_). | |||
* Do not reset the steering wheels to ``0.0`` on timeout (`#1289 <https://github.com/ros-controls/ros2_controllers/pull/1289>`_). | |||
* New parameter ``reduce_wheel_speed_until_steering_reached`` was added. If set to true, then the wheel speed(s) is reduced until the steering angle has been reached. Only considered if ``open_loop = false`` (`#1314 <https://github.com/ros-controls/ros2_controllers/pull/1314>`_). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this "new", if yes for how long we keep it that way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is part of the release notes, so I think that "new" is appropriate here?
Some features are missing in the library to feature-equally integrate the older tricycle_controller (#850).
reduce_wheel_speed_until_steering_reached
is one step closer.The old code
ros2_controllers/tricycle_controller/src/tricycle_controller.cpp
Lines 173 to 189 in 97c1e24
I modified the function a bit to be continuously differentiable
This breaks ABI of the odometry class, but I don't think that lots of people use this directly without the derived controllers.