Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of using in examples and use hardware_interface::CallbackReturn instead #171

Closed
2 tasks
destogl opened this issue Apr 15, 2022 · 0 comments · Fixed by #173
Closed
2 tasks

Remove use of using in examples and use hardware_interface::CallbackReturn instead #171

destogl opened this issue Apr 15, 2022 · 0 comments · Fixed by #173
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@destogl
Copy link
Member

destogl commented Apr 15, 2022

With changes in ros-controls/ros2_control/pull/673 we had to add additional using in examples for the code to be compilable.

@fmauch gave us a great idea here, to actually use hardware_interface::CallbackReturn instead. This is much more future-proof!

Here you should do the following:

  • remove all using CallbackReturn = rclcpp_lifecycle::node_interfaces::LifecycleNodeInterface::CallbackReturn; definition from examples
  • use hardware_interface::CallbackReturn instead of CallbackReturn in the delcarations and definitions and for constants-access.
@destogl destogl added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 15, 2022
@destogl destogl linked a pull request Feb 2, 2023 that will close this issue
@destogl destogl closed this as completed Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant