Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate version.h file per package using the ament_generate_version_header (backport #1449) #1938

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 12, 2024

These changes of this PR allow the ros2_control packages to have the version.h generated by the ament_cmake_gen_version_h


This is an automatic backport of pull request #1449 done by Mergify.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's the same issue we faced with joint limits the other time. Maybe we can skip it for this iteration

joint_limits/CMakeLists.txt Show resolved Hide resolved
joint_limits/package.xml Show resolved Hide resolved
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.98%. Comparing base (8164fc5) to head (489c26e).
Report is 1 commits behind head on humble.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1938      +/-   ##
==========================================
- Coverage   63.01%   62.98%   -0.03%     
==========================================
  Files         109      109              
  Lines       12450    12450              
  Branches     8445     8445              
==========================================
- Hits         7845     7842       -3     
- Misses        842      844       +2     
- Partials     3763     3764       +1     
Flag Coverage Δ
unittests 62.98% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@christophfroehlich christophfroehlich merged commit 5bce7bf into humble Dec 13, 2024
11 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1449 branch December 13, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants