Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CPU affinity parameter to be able to set multiple CPUs #1915

Merged

Conversation

saikishor
Copy link
Member

@saikishor saikishor commented Dec 4, 2024

This PR changes the strategy on handling CPU affinity. The changes here allow to use multiple CPUs instead of a single one as in previous implementation

Similar approach as #1898

@saikishor
Copy link
Member Author

@firesurfer Can you take a look at the changes?

Copy link
Contributor

@firesurfer firesurfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the missing documentation update this looks fine!

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 87.75%. Comparing base (3d57fc8) to head (9b588e9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
controller_manager/src/ros2_control_node.cpp 10.00% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1915      +/-   ##
==========================================
- Coverage   87.83%   87.75%   -0.08%     
==========================================
  Files         122      122              
  Lines       12926    12939      +13     
  Branches     1153     1155       +2     
==========================================
+ Hits        11353    11355       +2     
- Misses       1148     1158      +10     
- Partials      425      426       +1     
Flag Coverage Δ
unittests 87.75% <10.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/ros2_control_node.cpp 66.66% <10.00%> (-9.93%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update that in the release notes?

@saikishor
Copy link
Member Author

Should we update that in the release notes?

Yes! You are right. I forgot that part 😅😅

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmagyar bmagyar merged commit 0ef99fe into ros-controls:master Dec 7, 2024
16 of 20 checks passed
@saikishor saikishor deleted the set/multiple/cpus/affinity branch December 7, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants