-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CPU affinity parameter to be able to set multiple CPUs #1915
Update CPU affinity parameter to be able to set multiple CPUs #1915
Conversation
@firesurfer Can you take a look at the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the missing documentation update this looks fine!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1915 +/- ##
==========================================
- Coverage 87.83% 87.75% -0.08%
==========================================
Files 122 122
Lines 12926 12939 +13
Branches 1153 1155 +2
==========================================
+ Hits 11353 11355 +2
- Misses 1148 1158 +10
- Partials 425 426 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update that in the release notes?
Yes! You are right. I forgot that part 😅😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR changes the strategy on handling CPU affinity. The changes here allow to use multiple CPUs instead of a single one as in previous implementation
Similar approach as #1898