Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working for MODX Revolution 2.3 #26

Open
DESIGNfromWITHIN opened this issue Jun 8, 2014 · 7 comments
Open

Not working for MODX Revolution 2.3 #26

DESIGNfromWITHIN opened this issue Jun 8, 2014 · 7 comments

Comments

@DESIGNfromWITHIN
Copy link

Am I right that ElementHelper is not working on MODX Revolution 2.3?
Would love to use it on my experimental installs!

@roryg
Copy link
Owner

roryg commented Jun 8, 2014

Hmm, probably not if big changes have been made to the way elements are handled in 2.3. I've only tested on the current stable version of Revolution so far but it looks like they're getting close to releasing 2.3 so I'll have to do something about that.

@mjpugh
Copy link

mjpugh commented Jul 1, 2014

I also just tried to use ElementHelper in the latest nightly release of MODX Revo 2.3, and it does not appear to be working. It would be really great to have ElementHelper ready for the Revo 2.3 public release. Do you have a new release of ElementHelper in the works?

@roryg
Copy link
Owner

roryg commented Jul 5, 2014

I've just seen Modx 2.3 is scheduled for release on the 15th so I'm going to try and have a new better version ready before then. :)

@Mark-H
Copy link

Mark-H commented Jul 22, 2014

What is actually broken in 2.3?

@Mark-H
Copy link

Mark-H commented Jul 22, 2014

Figured I'd go through the source to see if I could spot anything that might be broken for 2.3.

https://github.com/roryg/ElementHelper/blob/master/core/components/elementhelper/elements/plugins/plugin.elementhelper.php#L10 and https://github.com/roryg/ElementHelper/blob/master/core/components/elementhelper/elements/plugins/plugin.elementhelper.php#L297 $modx->getMicroTime() has been deprecated for a long time and should not have been used. It was removed in 2.3. Use microtime(true) instead.

That's the only thing that stood out for me in the source.

@sonicpunk
Copy link

Is this going to get updated for use in 2.3?

@roryg
Copy link
Owner

roryg commented Jan 6, 2015

@sonicpunk I'm working on a new version that you can download here #31

Unfortunately things keep coming up that prevent me from finishing it so I can't say when it will be completely done. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants