From 74baabcd0b595fa2c3591b0e8c7c54b0ac927158 Mon Sep 17 00:00:00 2001 From: wlandau Date: Fri, 25 Aug 2023 16:46:48 -0400 Subject: [PATCH] Fix #1127 --- NEWS.md | 1 + inst/WORDLIST | 1 + tests/gcp/test-prefix.R | 5 +++-- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/NEWS.md b/NEWS.md index 5ca072735..9e736d83c 100644 --- a/NEWS.md +++ b/NEWS.md @@ -22,6 +22,7 @@ Because of these changes, upgrading to this version of `targets` will unavoidabl * Retry all cloud REST API calls on HTTP 500 errors with the exponential backoff algorithm from `googleAuthR` (#1112). * Make cloud temp file instances unique in order to avoid file conflicts with the same target. * For `format = "url"`, only retry on HTTP 500 error codes. +* Un-deprecate `seconds_interval` and `seconds_timeout` from `tar_resources_url()`, and implement `max_tries` arguments in `tar_resources_aws()` and `tar_resources_gcp()` (#1127). # targets 1.2.2 diff --git a/inst/WORDLIST b/inst/WORDLIST index d5a0cba00..c0364c664 100644 --- a/inst/WORDLIST +++ b/inst/WORDLIST @@ -33,6 +33,7 @@ bugfixes Bugfixes cancelled Carpentries +jitter changelog Changelog checksum diff --git a/tests/gcp/test-prefix.R b/tests/gcp/test-prefix.R index d9305bb4d..acb4844ea 100644 --- a/tests/gcp/test-prefix.R +++ b/tests/gcp/test-prefix.R @@ -17,7 +17,8 @@ tar_test("gcp_parquet format returns data frames", { resources = tar_resources( gcp = tar_resources_gcp( bucket = !!bucket_name, - prefix = "custom/prefix" + prefix = "custom/prefix", + max_tries = 20 ) ), format = "parquet", @@ -36,7 +37,7 @@ tar_test("gcp_parquet format returns data frames", { gcp_gcs_exists( key = "custom/prefix/objects/x", bucket = bucket_name, - max_tries = 5L + max_tries = 20L ) ) })