Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with tarchetypes CRAN feedback #17

Closed
6 tasks done
wlandau opened this issue Jan 30, 2021 · 1 comment
Closed
6 tasks done

Update with tarchetypes CRAN feedback #17

wlandau opened this issue Jan 30, 2021 · 1 comment
Assignees

Comments

@wlandau
Copy link
Member

wlandau commented Jan 30, 2021

Prework

  • Read and agree to the code of conduct and contributing guidelines.
  • If there is already a relevant issue, whether open or closed, comment on the existing thread instead of posting a new issue.
  • For any problems you identify, post a minimal reproducible example like this one so the maintainer can troubleshoot. A reproducible example is:
    • Runnable: post enough R code and data so any onlooker can create the error on their own computer.
    • Minimal: reduce runtime wherever possible and remove complicated details that are irrelevant to the issue at hand.
    • Readable: format your code according to the tidyverse style guide.

Description

  • use tempfiles more
  • ensure Rd files have @return explaining target objects.
@wlandau wlandau self-assigned this Jan 30, 2021
@wlandau
Copy link
Member Author

wlandau commented Feb 5, 2021

Should be done now.

@wlandau wlandau closed this as completed Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant