diff --git a/NEWS.md b/NEWS.md index b9cdb93..2ab2e47 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,7 @@ +# skimr 2.2.0 + +* Update handling of spark graphs for Windows when UTF-8 is supported. + # skimr 2.1.5 * Updated to work with newer version of purrr diff --git a/R/utils.R b/R/utils.R index 97da1b6..3663a8b 100644 --- a/R/utils.R +++ b/R/utils.R @@ -1,12 +1,12 @@ #' Fix unicode histograms on Windows #' #' This functions changes your session's locale to address issues with printing -#' histograms on Windows. +#' histograms on Windows on versions of R below 4.2.1. #' #' There are known issues with printing the spark-histogram characters when #' printing a data frame, appearing like this: "". #' This longstanding problem originates in the low-level code for printing -#' dataframes. +#' dataframes. This was addressed in R version 4.2.1. #' #' @seealso [skim_without_charts()] #' @export diff --git a/README.Rmd b/README.Rmd index e6ae50e..0624071 100644 --- a/README.Rmd +++ b/README.Rmd @@ -214,7 +214,8 @@ line charts in various contexts, some of which are described below. ### Support for spark histograms -There are known issues with printing the spark-histogram characters when +With versions of R before 4.2.1, there are known issues with +printing the spark-histogram characters when printing a data frame. For example, `"▂▅▇"` is printed as `""`. This longstanding problem [originates in the low-level @@ -222,7 +223,8 @@ code](https://stat.ethz.ch/pipermail/r-devel/2015-May/071250.html) for printing dataframes. While some cases have been addressed, there are, for example, reports of this issue in Emacs ESS. While this is a deep issue, there is [ongoing -work to address it in base R](https://blog.r-project.org/2020/05/02/utf-8-support-on-windows/). +work to address it in base R](https://blog.r-project.org/2020/05/02/utf-8-support-on-windows/). +We recommend upgrading to at least R 4.2.1 to address this issue. This means that while `skimr` can render the histograms to the console and in RMarkdown documents, it cannot in other circumstances. This includes: diff --git a/README.md b/README.md index 55d0159..6f9b065 100644 --- a/README.md +++ b/README.md @@ -434,15 +434,16 @@ and line charts in various contexts, some of which are described below. ### Support for spark histograms -There are known issues with printing the spark-histogram characters when -printing a data frame. For example, `"▂▅▇"` is printed as -`""`. This longstanding problem [originates in -the low-level +With versions of R before 4.2.1, there are known issues with printing +the spark-histogram characters when printing a data frame. For example, +`"▂▅▇"` is printed as `""`. This longstanding +problem [originates in the low-level code](https://stat.ethz.ch/pipermail/r-devel/2015-May/071250.html) for printing dataframes. While some cases have been addressed, there are, for example, reports of this issue in Emacs ESS. While this is a deep issue, there is [ongoing work to address it in base -R](https://blog.r-project.org/2020/05/02/utf-8-support-on-windows/). +R](https://blog.r-project.org/2020/05/02/utf-8-support-on-windows/). We +recommend upgrading to at least R 4.2.1 to address this issue. This means that while `skimr` can render the histograms to the console and in RMarkdown documents, it cannot in other circumstances. This