New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function naming strategy #11

Closed

ShixiangWang opened this issue Jul 23, 2019 · 1 comment

Assignees

Labels

plan

Member

ShixiangWang commented Jul 23, 2019

Comments from ropensci/software-review#315

Argument naming is not consistent - for example, the fetch_ API functions are in snake_case but a number of other functions are camel-cased with the first letter capitalized (i.e. XenaScan) or regular camel-cased (getTCGAdata). It would be helpful to adopt a similar casing style even if snake_case doesn't work because of consistency with other tools for these data sets.

This issue should be fixed in the next incompatible version.

ShixiangWang self-assigned this

ShixiangWang added the plan label

Member Author

ShixiangWang commented Oct 18, 2019

不太现实，闭了

ShixiangWang closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment