Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vignettes #4

Closed
isteves opened this issue May 27, 2018 · 1 comment
Closed

Vignettes #4

isteves opened this issue May 27, 2018 · 1 comment

Comments

@isteves
Copy link

isteves commented May 27, 2018

Hey @azizka, do you have the Rmd version of the PDFs in the Tutorials folder? I saw a few typos as I was reading through it, and I would be happy to help fix them if you have an Rmd (that way I can easily PR). Moving them into a vignettes folder would also be helpful so that it's consistent with other R packages. http://r-pkgs.had.co.nz/vignettes.html

You'll have the rest of the review/comments from me by the end of the long weekend! (We've got Monday off this week.)

rOpenSci review: ropensci/software-review#210
@azizka
Copy link
Collaborator

azizka commented May 28, 2018

Hi @isteves , thanks!
The .Rmd files are in the tutorial folder now. Thanks for the suggestion to include them as proper vignettes, I'll do so, when I work through your report.

@azizka azizka closed this as completed May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@azizka @isteves