Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Use dplyr best practices #47

Closed
adamhsparks opened this issue Aug 7, 2017 · 1 comment
Closed

Use dplyr best practices #47

adamhsparks opened this issue Aug 7, 2017 · 1 comment

Comments

@adamhsparks
Copy link
Collaborator

I'm not sure if this has the potential to cause any problems for some users, but it might be worthwhile to try to revise the code to use some of the recommended techniques for standard evaluation when programming with tidyverse packages rather than getting around CRAN notes by defining column names in dataframes as NULL within functions (i.e., all the spots noted now with # CRAN NOTE avoidance). I know that the underscore alternative dplyr functions can do that (mutate_ rather than mutate), but I think they've been deprecated now. I think the latest best practices are outlined here: http://dplyr.tidyverse.org/articles/programming.html

From ropensci/software-review#121 (comment)

@adamhsparks
Copy link
Collaborator Author

It took several commits, but this is now done.

The code now uses rlang::.data, however, this won't work with tidyr functions yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant