Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jam to Raspiblitz WebUI #2891

Closed
rootzoll opened this issue Jan 16, 2022 · 12 comments · Fixed by #3321
Closed

Add Jam to Raspiblitz WebUI #2891

rootzoll opened this issue Jan 16, 2022 · 12 comments · Fixed by #3321
Milestone

Comments

@rootzoll
Copy link
Collaborator

For v1.7.2 the JoinMarket WebUI was merged but just available thru commandline install - see #2747

For v1.8 update and integrate into SSH and Web one-click install menus.

@rootzoll rootzoll added this to the 1.8 Release milestone Jan 16, 2022
openoms added a commit that referenced this issue Feb 18, 2022
change LAN connection to HTTPS-only
add to CHANGES.md
#2891
joinmarket-webui/jam#16
@rootzoll rootzoll changed the title Add to Install Menue: JoinMarket Web UI Add to Install Menu & WebUI: JoinMarket Web UI Mar 9, 2022
@rootzoll rootzoll modified the milestones: 1.8.0 Release, 1.8.1 Release May 9, 2022
@rootzoll
Copy link
Collaborator Author

rootzoll commented May 9, 2022

The RaspiBlitz will start for v1.8.0 with just a limited set of apps to install over WebUI - but JoinMarket is a hot candidate for a quick follow up 1.8.1 release.

@dergigi
Copy link
Contributor

dergigi commented May 19, 2022

JoinMarket is a hot candidate for a quick follow up 1.8.1 release

Awesome! v0.0.6 will be quite okay already, and I hope that we'll be having something proper (and almost feature-complete) with v0.0.7. Getting there!

@openoms openoms changed the title Add to Install Menu & WebUI: JoinMarket Web UI Add to Install Menu & WebUI: Jam (JoinMarket Web UI) Sep 28, 2022
@openoms
Copy link
Collaborator

openoms commented Sep 28, 2022

Related PR: #3321

A few more tasks:

@openoms openoms mentioned this issue Sep 30, 2022
6 tasks
@openoms openoms mentioned this issue Oct 28, 2022
@rootzoll
Copy link
Collaborator Author

rootzoll commented Nov 9, 2022

TODO: Make it WebUI ready. @openoms image content & description needed.

@openoms
Copy link
Collaborator

openoms commented Nov 9, 2022

Referring to https://jamapp.org/

@cstenglein
Copy link
Collaborator

Added issue here as well raspiblitz/raspiblitz-web#519

@cstenglein cstenglein added the WebUI issues relating the WebUI label Nov 10, 2022
@rootzoll
Copy link
Collaborator Author

Because of time constrains - pushing this to v1.10

@openoms openoms changed the title Add to Install Menu & WebUI: Jam (JoinMarket Web UI) Add Jam to Raspiblitz WebUI Dec 14, 2022
@rootzoll
Copy link
Collaborator Author

rootzoll commented Dec 18, 2022

OK Backend & WebUI prepared: raspiblitz/raspiblitz-web#545 (comment)

ToDo on RaspiBlitzScripts:

  • install/on fatpack
  • status

@rootzoll
Copy link
Collaborator Author

OK I prepared the installscripts of JAM (and JoinMarket as dependency) for the need to be installed by WebUI - see & test on branch: 2891-webuiapps - BUT there is one thing thats still a bit tricky:

@openoms I added in that branch the install action on the JAM & JoinMarket install scripts. But still the most of the joinmarket install is happening in the on section - I think on calling a script from JoinInBox here: https://github.com/rootzoll/raspiblitz/blob/6bd2e38f610aadcb22e02fd03ec37b266eed50cd/home.admin/config.scripts/bonus.joinmarket.sh#L228 .. is there a way to already call just the install/compile without the inital config? So when the WebUI calls the on it will not take multiple minutes anymore?

@openoms
Copy link
Collaborator

openoms commented Dec 19, 2022

The install option can call only the install without config with:

sudo -u joinmarket /home/joinmarket/install.joinmarket.sh -i install

Then the on option can do:

# configure joinmarket (includes a check if it is installed)
sudo -u joinmarket /home/joinmarket/start.joininbox.sh

# set the raspiblitz.conf
/home/admin/config.scripts/blitz.conf.sh set joinmarket "on"

rootzoll added a commit that referenced this issue Dec 19, 2022
* webapi branches

* add thunderhub off

* webui JAM & joinmarket

* fix joinmarket menu

* comment output

* add debug

* remove user delete JAM

* pipe outputs

* add to fatpack

* pipe more debug

* dont remove app

* force https

* #3544 manual merge

* separate install and on option for joinmarket (#3544)

* fix call

* adapt api/webui branches

Co-authored-by: openoms <[email protected]>
@rootzoll rootzoll added the final testing was fixed - needs testing label Dec 19, 2022
rootzoll added a commit that referenced this issue Dec 19, 2022
rootzoll added a commit that referenced this issue Dec 19, 2022
rootzoll added a commit that referenced this issue Dec 19, 2022
@rootzoll
Copy link
Collaborator Author

rootzoll commented Dec 19, 2022

@openoms the install section of the joinmarket install script had still a lot of config section that require the HDD/SSD being already available in it - I think I moved most of them over in to the on section (see branch 2891-fix as long as not merged) but I think I still saw some references of the JoinInBox referring to /home/joinmarket which later on in the on section gets linked to /mnt/hdd/app-data/.joinmarket .. are you sure there is no config going on when calling install.joinmarket.sh -i install.

gpg: Signature made Sun 09 Oct 2022 13:50:05 BST
gpg:                using RSA key 13C688DB5B9C745DE4D2E4545BFB77609B081B65
gpg: Good signature from "openoms <[email protected]>" [unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 13C6 88DB 5B9C 745D E4D2  E454 5BFB 7760 9B08 1B65
# goodSignature(1)
# correctKey(1)

##########################################################################
# OK --> the PGP signature of the checked out v0.7.4 tag is correct
##########################################################################

cp: -r not specified; omitting directory '/home/joinmarket/joininbox/scripts/jam-remote'
cp: -r not specified; omitting directory '/home/joinmarket/joininbox/scripts/standalone'
# Set ssh access off with the joinmarket user
grep: /home/joinmarket/joinin.conf: No such file or directory
joinmarketSSH=on

# Disable ssh access with the joinmarket user
touch: cannot touch '/home/joinmarket/joinin.conf': Permission denied

Please during ReleaseCadidate make sure to test all of JAM on the RaspiBlitz fatpack image - and not just on the VMs, etc.

rootzoll added a commit that referenced this issue Dec 20, 2022
* #2891 fix install blips

* #2891 move wallet

* add exit

* #2891 move config over to `on` section
@rootzoll rootzoll removed final testing was fixed - needs testing WebUI issues relating the WebUI labels May 11, 2023
@rootzoll
Copy link
Collaborator Author

rootzoll commented May 11, 2023

OK Jam will be part of the next v1.9.0 release. Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants