-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styles not compiling by default #746
Comments
I had a similar problem when I edited Run |
Hi @retlehs Sorry I have duplicated issues because one was auto-closed. Just copying this here from the closed issue: This is the full terminal output without changing anything out of the box. No scss files, just .css with the tailwind @apply.
|
you can run your build with the bud will display anything on process.stderr and will also report on errors from webpack stats object. i don't know that it handles warnings at the moment. i'll look into improving this more in the future, but it's why I built in the the next release will include a fix for It should fix this warning, in particular:
@gitgudcameron it was really hard to read your terminal output. please consider posting in a ``` block in the future. I edited your comment to make it easier to read this issue but it can't do anything about the lack of line breaks. anyway, the terminal output you posted is not "out of the box", as you are currently only specifying
since you only have .css files in your |
Thanks for the response @kellymears and for the formatting tips (sorry about that). I accidentally sent the wrong output too so I just did another clean install and the CSS do not compile with the default Tailwind @apply CSS and no warnings that I can see. Here is the output below if it helps. I'm in the process of upgrading my old Sage 10 theme that uses sass so I think what I really need is to look into implementing bud-sass so I'll check that out. Thanks
|
@gitgudcameron can you:
thanks! |
Is this resolved? [your-theme-name] [build] › ⚠ build.make: excluding experiments value is undefined |
If there is strict linting, is there an easy way to fix them all? |
I figured this was due to the stylelint errors. |
I think the stderr rendering is behaving normally for stylelint errors. Rendering of stderr messages by @roots/bud-dashboard was improved in #776. I'm not sure what beta release that correlates with but regardless the [email protected] dashboard renders stderr messages with sage as it comes out-of-the-box. If you write css that is straight-up broken, the expected stack traces are displayed, followed by a simple message.
If you have any concerns that you are missing a build-related message you can confirm by using the On sass configIf you are using sass you will need to update your stylelint config to handle sass syntax. I wrote up a quick rundown of what all you need to do to support scss syntax in stylelint here: I think it's likely this will be part of the base stylelint config in the future in cases where Other possible known issueIf you still get a warning related to scss and postcss you can fix it with this snippet: bud.hooks.on('extension.@roots/bud-postcss.options', (options) => ({
...options,
syntax: 'postcss-scss',
})) I attempted to fix this in #737 but I don't think I was entirely successful. I am now hopeful that #779 will fix this issue. Thankfully, tapping the hook from user config seems to work 100% of the time. ref #732 |
Description
Styles not compiling by default.
Steps to reproduce
Expected behavior:
The editor.css and app.css should be compiled into the "public" folder but are not by default. However, no error is displayed.
Reproduces how often:
Every time.
Additional information
When linting something other than CSS, you should install an appropriate syntax, e.g. "postcss-scss", and use the "customSyntax" option.
I've tried "yarn add postcss-scss --dev" and tweaking the stylelint config file but not having any luck.
The text was updated successfully, but these errors were encountered: