Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all integration benchmarks run with equal file cache conditions #154

Open
eguiraud opened this issue Jul 16, 2020 · 1 comment

Comments

@eguiraud
Copy link
Member

Currently we have a few integration benchmarks that only execute a single repetition, but some of these benchmarks share input files. As a consequence, the first of these benchmarks would run on a cold file cache and the others on a warm cache. We have to normalize this, e.g. by having each integration test run two iterations and discarding the runtime of the first.

@vgvassilev
Copy link
Member

Isn't that a job of the benchmark itself rather than the infrastructure?

The benchmark author should ensure the run conditions in the benchmark initialization phase. Indeed if the intent is to benchmark on cold cache, then we have a little to do as previous benchmarks may have forced the kernel to load data files.

I would be in favor of that approach rather controlling this indirectly by infrastructure at the cost of making it complicated.

Do you see such effect somewhere at the moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants