Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMethodError: read_cells for Roo::Excelx when using parse with clean: true (XLSX) #182

Closed
reshleman opened this issue Mar 11, 2015 · 1 comment

Comments

@reshleman
Copy link
Contributor

Attempting to call parse on an xlsx spreadsheet with clean: true results in:

NoMethodError: undefined method `read_cells' for #<Roo::Excelx>

I'm encountering this on the latest revision of master, which Roo::VERSION claims to be 2.0.0, but which is actually un-tagged and un-released on RubyGems.

I've created a gist with reproduction steps and a backtrace, in case that's helpful.
https://gist.github.com/reshleman/effae77c02e48305917c

@reshleman reshleman changed the title NoMethodError: read_cells for Roo::Excelx when using parse with clean: true NoMethodError: read_cells for Roo::Excelx when using parse with clean: true (XLSX) Mar 11, 2015
@stevendaniels
Copy link
Contributor

I did some investigating.

For some reason, Roo::Excelx doesn't have read_cells method like Roo::CSV and Roo::OpenOffice.

All Roo::Base methods that reference the read_cells except for clean_sheet are overridden. This issue could be fixed by overriding clean_sheet method to Roo::Excelx.

I'm working on tests and a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants