This manifesto collects 10 practices of how to conduce a code review using an agile approach. It seeks to focus in what was developed, to share better understanding of requirements and keep people close and working together as a team.
It is based on Agile Manifesto along with my experience as software developer on agile teams.
The described practices here are not rules and represents a particular point of view as an opinion of how to approach the code review activity. Some practices might work or not for you situation. Consider to adapt accondingly with you needs.
- Keep code code working is more important than review a code that does not work
- Use tools to analyze the code for you. This will save you a lot of time (and your team's too).
- Define a code standard (or use an existing one). The team must develop the code following a pattern.
- Don't forget, the code was written by people, not machines.
- Giving a suggestion for improvement is worth more than just pointing out mistakes.
- Own the code you are reviewing. You also own it, not just who developed it.
- Think of code review as a time to learn. Whether the code was developed by you or not.
- Base your statements on good practices of the language and/or the community.
- Communicate with your team. Understanding the code together with your team is more important than guessing or making assumptions.
- Detach yourself from the code you developed. The code is constantly evolving. And you must be evolving too.