This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!bench_formatter |
Parser conformance results on ubuntu-latestjs/262
➕ Added Tests (605):
➖ Removed Tests (50):
jsx/babel
ts/babel
ts/microsoft
🔥 Regression (2):
➕ Added Tests (88):
➖ Removed Tests (2):
|
Deploying with Cloudflare Pages
|
Formatter Benchmark Results
|
This won't show any meaningful result because none of the libraries use (or at least not heavily) bigints. |
MichaReiser
approved these changes
Apr 20, 2022
crates/rome_js_formatter/src/js/expressions/big_int_literal_expression.rs
Outdated
Show resolved
Hide resolved
Formatter Benchmark Results
|
xunilrj
force-pushed
the
feature/normalize-bigint-literals
branch
from
April 20, 2022 17:44
53e97c3
to
cf4b212
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #2426
to_ascii_lowercase_cow
For this task, I don't need a general Unicode to_lowercase, and Rust as of today only give me access to lowering the case of a Unicode through
char::to_lowercase
which returns an iterator (because of some crazy languages!).This made my method slower than calling
str::to_lowercase
.If I simplify the assumption to support only ASCII, I can make my method faster and avoid allocations.