Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

🐛 new line only formatter diff #3375

Closed
1 task done
MichaReiser opened this issue Oct 10, 2022 · 1 comment · Fixed by #3382
Closed
1 task done

🐛 new line only formatter diff #3375

MichaReiser opened this issue Oct 10, 2022 · 1 comment · Fixed by #3382
Assignees
Labels
A-Diagnostic Area: errors and diagnostics S-Bug: confirmed Status: report has been confirmed as a valid bug
Milestone

Comments

@MichaReiser
Copy link
Contributor

MichaReiser commented Oct 10, 2022

Environment information

Input file

declare module "test" {
	interface A {

		prop: string;
	}
}

What happened?

  1. Run rome format: cargo run --bin rome --release format ./test/
  2. Observe how Rome prints an empty diff
./test/test.d.ts format ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ℹ Formatter would have printed the following content:
  
  

Compared 1 files in 1277µs

Expected result

I expect a diff that highlights that the empty line before the prop: string has been removed.

Code of Conduct

  • I agree to follow Rome's Code of Conduct
@MichaReiser MichaReiser added the S-To triage Status: user report of a possible bug that needs to be triaged label Oct 10, 2022
@MichaReiser MichaReiser added this to the 10.0.0 milestone Oct 10, 2022
@MichaReiser
Copy link
Contributor Author

@leops would you mind taking a look at this issue?

@MichaReiser MichaReiser added S-Bug: confirmed Status: report has been confirmed as a valid bug A-Diagnostic Area: errors and diagnostics and removed S-To triage Status: user report of a possible bug that needs to be triaged labels Oct 10, 2022
@leops leops self-assigned this Oct 10, 2022
@leops leops moved this to Done in Rome 2022 Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Diagnostic Area: errors and diagnostics S-Bug: confirmed Status: report has been confirmed as a valid bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants