Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing regex overrides with FQCNs in the map. #51

Open
JakeWharton opened this issue Jan 3, 2018 · 3 comments
Open

Consider replacing regex overrides with FQCNs in the map. #51

JakeWharton opened this issue Jan 3, 2018 · 3 comments

Comments

@JakeWharton
Copy link
Collaborator

JakeWharton commented Jan 3, 2018

This would allow doing stuff like:

"android.telephony": { .. },
"android.telephony.gsm.SmsManager": { .. },
"android.telephony.gsm.SmsMessage": { .. },

to solve #50, for example, as well as #44 and all the existing cases handled by regex.

@JakeWharton
Copy link
Collaborator Author

JakeWharton commented Jan 3, 2018

I'm doing this here JakeWharton/SdkSearch@6048d43...4d08355 and it's working well.

@romannurik
Copy link
Owner

I'd love to accept a PR that rethinks how the mapping works, and better yet, shares a mapping with your SdkSearch project :) As a side note, I regret not writing unit tests for the mapping :-/

@JakeWharton
Copy link
Collaborator Author

JakeWharton commented Jan 4, 2018

I'll see if I can come up with something that works and allows both projects to remain in sync relatively easily.

shares a mapping with your SdkSearch project

Long term I want to make SdkSearch a Kotlin multi-platform project and eat your extension so that they can share sync-ing, searching, and source-mapping, but that's a really long-term plan.

regret not writing unit tests for the mapping

I wrote a helper which enumerates all known classes and does an HTTP HEAD request to the source URL to find whether it's valid or not. It's works great (aside from the sleeps to avoid rate limiting).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants