-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider replacing regex overrides with FQCNs in the map. #51
Comments
I'm doing this here JakeWharton/SdkSearch@6048d43...4d08355 and it's working well. |
I'd love to accept a PR that rethinks how the mapping works, and better yet, shares a mapping with your SdkSearch project :) As a side note, I regret not writing unit tests for the mapping :-/ |
I'll see if I can come up with something that works and allows both projects to remain in sync relatively easily.
Long term I want to make SdkSearch a Kotlin multi-platform project and eat your extension so that they can share sync-ing, searching, and source-mapping, but that's a really long-term plan.
I wrote a helper which enumerates all known classes and does an HTTP HEAD request to the source URL to find whether it's valid or not. It's works great (aside from the sleeps to avoid rate limiting). |
This would allow doing stuff like:
to solve #50, for example, as well as #44 and all the existing cases handled by regex.
The text was updated successfully, but these errors were encountered: