-
Notifications
You must be signed in to change notification settings - Fork 17
[createFilter] Add an option to include virtual modules? #54
Comments
Could you check if #61 solves this for you (by specifying |
@lukastaegert IIRC, vue plugin uses something like Anyway, if commonjs decide to change their ID and the ID can be processed by other plugins, this shouldn't be an issue anymore. Since it is intended to prevent virtual modules from being processed by plugins according to the doc:
This issue probably shouldn't be handled by #61. |
The common-js proxy modules contain hardly any code and the plugin relies on the fact that no other plugins mess with this code. Therefore I would be very careful to remove the For the issue with the globals plugin, this is a special case in that we rely on this specific behaviour of rollup-plugin-commonjs to translate require statements to something we understand. So maybe (once we changed rollup-plugin-commonjs), rollup-plugin-globals could handle this the following way:
|
With this comment, maybe I revert the change to allow ids starting with a |
I have changed the commonjs proxy format in rollup/rollup-plugin-commonjs#387 and removed the automatic resolution of private ids again from #61 |
We've moved this repo to https://github.com/rollup/plugins. If anyone would like to re-submit this issue there, we'd welcome it. |
Currently, virtual modules are excluded by default. This prevents external-globals plugin from processing proxy modules generated by commonjs plugin. How do we handle this situation?
The text was updated successfully, but these errors were encountered: