Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Typescript forgotten helper __assign #49

Closed
MartynasZilinskas opened this issue Jul 15, 2016 · 5 comments
Closed

Typescript forgotten helper __assign #49

MartynasZilinskas opened this issue Jul 15, 2016 · 5 comments
Labels
bug

Comments

@MartynasZilinskas
Copy link

After "bundling" code __assign typescript-helper is missing.
image
@MartynasZilinskas MartynasZilinskas changed the title Typescript forgot helper __assign Typescript forgotten helper __assign Jul 15, 2016
@Victorystick
Copy link
Contributor

The TypeScript __assign helper still wasn't around when we started bundling the helpers. Fortunately, it appears that Microsoft have created tslib which contains the complete set of ES6 helpers that will be maintained by the TypeScript devs. We should definitely prefer that over our local copy.

@Victorystick
Copy link
Contributor

Hmm... Sadly, they've decided against including the __extends helper in the ES6 version of tslib. What a shame. They likely assume that tslib.es6.js will only be used in environments with native class support; which excludes us.

I guess we'll just add the __assign helper ourselves for now.

@Victorystick
Copy link
Contributor

@MartynasZilinskas Are you using a nightly build? Object spread doesn't seem to be due until the next TypeScript release.

@MartynasZilinskas
Copy link
Author

Hey @Victorystick. Thanks for your fast response. I am currently using 1.8.10 version.

@Victorystick Victorystick mentioned this issue Jul 18, 2016
Merged
@Victorystick
Copy link
Contributor

Released as 0.7.7!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MartynasZilinskas @Victorystick