Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Update README.md with note on symlinks #405

Merged
merged 4 commits into from
Aug 22, 2019
Merged

Conversation

bterlson
Copy link
Contributor

This addresses the confusion reported in #402

IMO it would be nice to make this easier on people by supporting includeModule/excludeModule, but in the meantime we should document symlinks a bit better.

This addresses the confusion reported in #402 

IMO it would be nice to make this easier on people by supporting includeModule/excludeModule, but in the meantime we should document symlinks a bit better.
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bterlson
Copy link
Contributor Author

Thanks for the review @shellscape, I've taken your suggestions.

Prefer specifying module names over paths
@bterlson bterlson requested a review from shellscape August 22, 2019 01:35
@bterlson
Copy link
Contributor Author

@shellscape can you double check the latest commit? I think the docs should prefer the module name form for namedExports since it's easier and more reliable.

Copy link
Contributor

@shellscape shellscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will merge this, but I guess this one does not require a dedicated release 😉

@lukastaegert lukastaegert merged commit e431c29 into master Aug 22, 2019
@lukastaegert lukastaegert deleted the bterlson-patch-1 branch August 22, 2019 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants