This repository has been archived by the owner on Aug 4, 2021. It is now read-only.
fix: remove colon from module prefixes #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Rollup with the `preserveModules` option set, it outputs all modules to files. External commonjs modules end up with a file name like `_commonjs-external:modulename`. Using a colon inside a file name is invalid and results in a lot of problems.
9 tasks
|
Thanks! Nevertheless, I prefer to actually fix this upstream: rollup/rollup#2792 |
|
Ok, seems colons are actually important on windows, so back to your approach... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Rollup with the
preserveModulesoption set, it outputs all modules to files. External commonjs modules end up with a file name like_commonjs-external:modulename. Using a colon inside a file name is invalid and results in a lot of problems.