Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

Rollup experimentalCodeSplitting #282

Closed
jthoms1 opened this issue Jan 24, 2018 · 1 comment
Closed

Rollup experimentalCodeSplitting #282

jthoms1 opened this issue Jan 24, 2018 · 1 comment

Comments

@jthoms1
Copy link
Contributor

jthoms1 commented Jan 24, 2018

With the release of [email protected] a new flag was created called experimentalCodeSplitting. This allows for a new code splitting mechanism that allows rollup to accept multiple entry points. It appears that this plugin is currently not compatible with this flag. I think it is a fair assumption many rollup users depend on this plugin.

Currently resolveId is used to gather the full path of the entry point file and it is then used to compare against the transform function. It appears this is a simple update to allow for arrays or strings. Would you be amenable to accepting a PR to fix this issue.

Path Resolution of a single filePath
https://github.com/rollup/rollup-plugin-commonjs/blob/master/src/index.js#L136

Comparison
https://github.com/rollup/rollup-plugin-commonjs/blob/master/src/index.js#L185

@lukastaegert
Copy link
Member

Resolved via #283

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants