Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type declarations for @rollup/plugin-html missing from npm package #801

Closed
flying-sheep opened this issue Feb 13, 2021 · 6 comments · Fixed by #802
Closed

Type declarations for @rollup/plugin-html missing from npm package #801

flying-sheep opened this issue Feb 13, 2021 · 6 comments · Fixed by #802

Comments

@flying-sheep
Copy link
Contributor

flying-sheep commented Feb 13, 2021

  • Rollup Plugin Name: @rollup/plugin-html
  • Rollup Plugin Version: 0.2.2

Feature Use Case

Using it from TypeScript

Feature Proposal

You should package the index.d.ts for @rollup/plugin-html

@shellscape
Copy link
Collaborator

Thanks for the issue. They aren't missing, because they were never developed. If someone would like to contribute them to the project, we'll be happy to have the contribution.

@flying-sheep
Copy link
Contributor Author

flying-sheep commented Feb 13, 2021

They’re right there: https://github.com/rollup/plugins/blob/287e554d57523f939c83ac9cc050e028c1fa43e9/packages/html/types/index.d.ts

Also the plugin is written in typescript, so they can be autogenerated, nobody needs to manually do anything except for including the file in the npm package.

@shellscape
Copy link
Collaborator

shellscape commented Feb 13, 2021

So your issue meant to say that they existed, but weren't included in the package files.

Wording matters 😄 Please PR an update to package.json when you have the opportunity.

@flying-sheep
Copy link
Contributor Author

flying-sheep commented Feb 13, 2021

I don’t know what needs to be changed, the path is there:

"types": "types/index.d.ts",

@flying-sheep flying-sheep changed the title Missing type declarations for @rollup/plugin-html Type declarations for @rollup/plugin-html missing from npm package Feb 13, 2021
@flying-sheep
Copy link
Contributor Author

flying-sheep commented Feb 13, 2021

Ah got it!

Should I also update the version or will you do that?

@shellscape
Copy link
Collaborator

Versioning is done automatically when we publish. Thanks for the PR, we'll continue discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants