You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Delimiters defaults to ['(?<!\\.)\\b', '\\b(?!\\.)']
Actual Behavior / Situation
Delimiters currently defaults to ['\\b', '\\b(?!\\.)']
Modification Proposal
The delimiters defaults are a little too permissive, which means that it's easy to have an error where globalThis.process.env.NODE_ENV gets transformed into globalThis."production" which causes error in dependencies.
I believe this fix should prevent other users from having the same issues in the future, and shouldn't break existing behaviours. However I am nowhere near a rollup expert and I could be wrong, so feel free to close this if this will break more things than it will fix.
If you think this is a good idea, I am happy to submit a PR with the implementation.
The text was updated successfully, but these errors were encountered:
Thanks for the issue. The best route for you would be to make the change and see what tests fail. That would give you (and us) a decent idea of the impact. It'd definitely be considered a breaking change, but that wouldn't stop us from releasing it.
Hey folks. This issue hasn't received any traction for 60 days, so we're going to close this for housekeeping. If this is still an ongoing issue, please do consider contributing a Pull Request to resolve it. Further discussion is always welcome even with the issue closed. If anything actionable is posted in the comments, we'll consider reopening it. ⓘ
Expected Behavior / Situation
Delimiters defaults to
['(?<!\\.)\\b', '\\b(?!\\.)']
Actual Behavior / Situation
Delimiters currently defaults to
['\\b', '\\b(?!\\.)']
Modification Proposal
The delimiters defaults are a little too permissive, which means that it's easy to have an error where
globalThis.process.env.NODE_ENV
gets transformed intoglobalThis."production"
which causes error in dependencies.See conversation and and example on how it happened with
graphql
andnitro
nuxt/nuxt#21768 (comment)I believe this fix should prevent other users from having the same issues in the future, and shouldn't break existing behaviours. However I am nowhere near a rollup expert and I could be wrong, so feel free to close this if this will break more things than it will fix.
If you think this is a good idea, I am happy to submit a PR with the implementation.
The text was updated successfully, but these errors were encountered: