Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(schedule): add status column filter #2284

Merged
merged 25 commits into from
Sep 11, 2023
Merged

feat(schedule): add status column filter #2284

merged 25 commits into from
Sep 11, 2023

Conversation

ThorsAngerVaNeT
Copy link
Contributor

🟢 Add deploy label if you want to deploy this Pull Request to staging environment

🧑‍⚖️ Pull Request Naming Convention

  • Title should follow Conventional Commits
  • Do not put issue id in title
  • Do not put WIP in title. Use Draft PR functionality
  • Consider to add area:* label(s)
  • I followed naming convention rules

🤔 This is a ...

  • New feature
  • Bug fix
  • Performance optimization
  • Refactoring
  • Test Case
  • Documentation update
  • Other

🔗 Related issue link

#1766

💡 Background and solution

The status column filter is reset when a tab is changed from the All tab.
image

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Database migration is added or not needed
  • Documentation is updated/provided or not needed
  • Changes are tested locally

@ThorsAngerVaNeT ThorsAngerVaNeT marked this pull request as draft September 6, 2023 12:36
@ThorsAngerVaNeT
Revert "refactor(mentor-registry): update FilteredTags"
8692f1b 
This reverts commit 8359fc7.
@ThorsAngerVaNeT
Revert "feat(schedule): refactor FilteredTags to handle multiple filt…
cccfaeb 
…er types, add handling to close status column filter"

This reverts commit 2bf62bf.
@ThorsAngerVaNeT
feat(scheduler): implement combined filter functionality for status a…
7328cc7 
…nd type columns
@ThorsAngerVaNeT
feat: replace deprecated onFilterDropdownVisibleChange
e05cf3f
@ThorsAngerVaNeT
refactor(schedule): rename property at getColumns
3ec6432
@ThorsAngerVaNeT
refactor(schedule): rename variable at TableView
0ae23e8
@ThorsAngerVaNeT
feat(schedule): move tagFilters state to combinedFilter as filterTags
9df0f62
@ThorsAngerVaNeT
refactor(schedule): delete unused LocalStorageKeys
2e817d8
@ThorsAngerVaNeT
test(schedule): update tests for new useLocalStorage structure
d2c228d
@ThorsAngerVaNeT
refactor(schedule): fix formatting
de8d3e6
@ThorsAngerVaNeT
Merge branch 'master' into feat/schedule-status-filter
de0ad5c
@ThorsAngerVaNeT ThorsAngerVaNeT marked this pull request as ready for review September 7, 2023 09:32
@ThorsAngerVaNeT ThorsAngerVaNeT merged commit 30b8478 into rolling-scopes:master Sep 11, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apalchys apalchys apalchys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThorsAngerVaNeT @apalchys